Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate sles legacy init-script support #184

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

floerica
Copy link

added a depending package (insserv-compat) to avoid strange errors on a fresh sles installation (/etc/init.d/.. not found)

@CLAassistant
Copy link

CLAassistant commented Apr 14, 2024

CLA assistant check
All committers have signed the CLA.

@floerica
Copy link
Author

as requested in #172 - here is the PR

Copy link
Member

@ishanjainn ishanjainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @gardar

@floerica
Copy link
Author

for whatever reason my next patch got integrated into here - this was not really intended - i guess it happened as i wanted to have my merge request into my main fork.. However here are the informations:

  • i added a few tasks in install.yml to prepare and update zypper
  • tested this on openSuSE Leap - works perfektly fine on a fresh installed system
  • tried to test on SLES15SP5 - but as my sles15sp5 is not registred within SuSe for proxy/firewall reasons, the grafana rpm install failes currently as some dependencies you can only get from SuSE Packagehub (firewall restrictions on my end) are not met
  • if i install the 2 dependent packages (freetype, libttf) manually, then the role and installation goes through as expected

If you have concerns adding both patches at the same time, feel free to close my PR and i will open 2 seperate ones to integrate this stuff

@ishanjainn
Copy link
Member

@gardar on this too, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants