Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Small improvements to the custom client #51709

Merged
merged 2 commits into from Jul 4, 2022
Merged

Prometheus: Small improvements to the custom client #51709

merged 2 commits into from Jul 4, 2022

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented Jul 4, 2022

Based on @bboreham suggestion from #51436.

These changes were already done in official Go prometheus client.
prometheus/client_golang#1022
prometheus/client_golang#976

@aocenas aocenas requested a review from a team as a code owner July 4, 2022 12:08
@aocenas aocenas added this to the 9.1.0 milestone Jul 4, 2022
@aocenas aocenas added no-backport Skip backport of PR datasource/Prometheus no-changelog Skip including change in changelog/release notes and removed datasource/Prometheus area/backend labels Jul 4, 2022
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24902

bboreham
bboreham approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; seems legit.

@aocenas aocenas closed this Jul 4, 2022
@aocenas aocenas reopened this Jul 4, 2022
@github-actions github-actions bot removed this from the 9.1.0 milestone Jul 4, 2022
@aocenas aocenas merged commit bf334ab into main Jul 4, 2022
@aocenas aocenas deleted the aocenas/prometheus/client-improvements branch July 4, 2022 20:55
@nmarrs nmarrs added this to the 9.1.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmylife itsmylife itsmylife approved these changes

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
area/backend datasource/Prometheus enterprise-ok no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
9.1.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aocenas @grafanabot @itsmylife @bboreham @nmarrs