Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboards: Provide better error messages in SaveDashboardAsForm #57866

Merged
merged 2 commits into from Nov 8, 2022
Merged

Dashboards: Provide better error messages in SaveDashboardAsForm #57866

merged 2 commits into from Nov 8, 2022

Commits on Oct 31, 2022

  1. Dashboards: Provide better error messages in SaveDashboardAsForm 

    The existing code uses `instanceof Error` to check for a `message` field
on the thrown object. The objects that are thrown are never instances of
the error interface. This change locally uses `any` so we can check for
a `message` field to display instead.
    @joeblubaugh
    joeblubaugh committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    b0fa095 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Create new ValidationError class instead of using "any" to check type.

    @joeblubaugh
    joeblubaugh committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    794cbd9 View commit details
    Browse the repository at this point in the history