Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.2.x] Dashboards: Provide better error messages in SaveDashboardAsForm #58432

Merged
merged 1 commit into from
Nov 9, 2022
Merged

[v9.2.x] Dashboards: Provide better error messages in SaveDashboardAsForm #58432

merged 1 commit into from
Nov 9, 2022

Commits on Nov 8, 2022

  1. Dashboards: Provide better error messages in SaveDashboardAsForm (#57866 

    )

The existing code uses `instanceof Error` to check for a `message` field on the thrown object. The objects that are thrown are never instances of the error interface. This change introduces a new type that extends Error so that the check works properly and displays a meaningful error message in the UI.

(cherry picked from commit f07da85)
    @joeblubaugh @grafanabot
    joeblubaugh authored and grafanabot committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f7eb15f View commit details
    Browse the repository at this point in the history