PoC: Support removal of unsafe-inline
from CSP
#87295
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
unsafe-inline
from their CSP<DragDropContext>
@emotion/css
imports to this custom instance__webpack_nonce__
correctly in dev modeindex.ts
and picked up correctlyDefinePlugin
to set it correctly.setAttribute('style', ...)
to use.style.setProperty()
orstyle.cssText
create-plugin
create-plugin
and rebuildi'm a little unsure whether we should deliver this. on the one hand, it moves us very close to the final goal. but without monaco, it's kind of pointless because we can't tell people to remove
unsafe-inline
since code query editors are broken without it and they are qUiTe iMpOrTaNt 馃槄Why do we need this feature?
unsafe-inline
from their CSPWho is this feature for?
unsafe-inline
from their CSPWhich issue(s) does this PR fix?:
For #51047
Special notes for your reviewer:
Please check that: