Skip to content

Commit

Permalink
Merge pull request #3114 from grafana/update-helm-repo-fix-deps
Browse files Browse the repository at this point in the history
Don't hardcode helm charts dependencies in shared release workflow
  • Loading branch information
zalegrala committed May 8, 2024
2 parents e7a151e + 3b56b02 commit 5fade78
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions .github/workflows/update-helm-repo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -145,19 +145,6 @@ jobs:
with:
version: v3.5.2

- name: Add dependency chart repos
# Todo replace this by https://github.com/grafana/helm-charts/issues/1534
run: |
helm repo add elastic https://helm.elastic.co
helm repo add grafana https://grafana.github.io/helm-charts
helm repo add prometheus https://prometheus-community.github.io/helm-charts
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo add bitnami-pre-2022 https://raw.githubusercontent.com/bitnami/charts/eb5f9a9513d987b519f0ecd732e7031241c50328/bitnami
helm repo add hashicorp https://helm.releases.hashicorp.com
helm repo add minio-new https://charts.min.io
helm repo add jetstack https://charts.jetstack.io
helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx
- name: Parse Chart.yaml
id: parse-chart
run: |
Expand All @@ -175,6 +162,21 @@ jobs:
fi
echo "packagename=${name}-${version}" >> $GITHUB_OUTPUT
- name: Add dependency chart repos
run: |
cd source
# Skip the header line and make sure that tabs are expanded into spaces
deps=$(helm dependency list "${{ steps.parse-chart.outputs.chartpath }}" | tail +2 | expand)
while read -r row; do
IFS=' ' read -ra parts <<< "$row"
name="${parts[0]}"
repo="${parts[2]}"
case "$repo" in
"https://"*) helm repo add "$name" "$repo" ;;
*) echo >&2 "Skipping dependency $name: unsupported schema for \"$repo\"" ;;
esac
done <<< "$deps"
- name: Install CR tool
run: |
mkdir "${CR_TOOL_PATH}"
Expand Down

0 comments on commit 5fade78

Please sign in to comment.