[tempo] fix: Conditionally enable jaeger-metrics port on service monitor #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mats Andresen <mats.andresen@gmx.de>
maandr
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno,
mdisibio,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
|
Can this get merged please? Current solution forces us to enable tempoQuery |
zanhsieh
changed the title
mapno
requested changes
Jan 16, 2024
Signed-off-by: MH <zanhsieh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently encountered a situation where the service monitor stopped scraping data. This occurred because the service monitor contained the port configuration
jaeger-metricsthat did not exist in the service unless.Values.tempoQuery.enabledwas enabled.Since the presence of the
jaeger-metricsport in the service is conditional, it should also be subject to the same condition in the service monitor.