[grafana] Add global image registry support for extraInitContainers #2748
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Vallone <vallonephilip@gmail.com>
pvallone
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
Signed-off-by: Philip Vallone <vallonephilip@gmail.com>
pvallone
commented
Oct 30, 2023
zanhsieh
approved these changes
Oct 31, 2023
|
An init container could be from any registry even ones outside the default global registry, please revert this. |
|
Please revert or revise. |
Closed
kashalls
added a commit
to kashalls/home-cluster
that referenced
this pull request
Nov 1, 2023
This reverts commit 80aab72.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a client sets
global.imageRegistry, that registry should override whatever registries are specified inextraInitContainers.