New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Enable autoscaling for Compactor #2817
Open
7onn
wants to merge
9
commits into
grafana:main
Choose a base branch
from
7onn:7onn/autoscaling-tempo-compactor
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7onn
requested review from
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
December 3, 2023 15:05
7onn
force-pushed
the
7onn/autoscaling-tempo-compactor
branch
from
December 3, 2023 15:07
2dd7c2c
to
690158b
Compare
7onn
changed the title
[tempo-distributed] Enable autocaling for Compactor
[tempo-distributed] Enable autoscaling for Compactor
Dec 3, 2023
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
7onn
force-pushed
the
7onn/autoscaling-tempo-compactor
branch
from
December 3, 2023 15:41
ad49e0c
to
715d176
Compare
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
zanhsieh
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #2820
This PR aims to enable autoscaling feature for the compactor workload in tempo-distrubuted Helm Chart.
It implements two autoscaling possibilities, via HPA and/or via ScaledObject.
My motivation came while I was oncall and one alert introduced me to this runbook. Even though I scaled out the workload manually, I couldn't help but to think that it would make sense to scale out this workload based on the metric that triggered the alert as a critical thing. The value commented in the example was copied from here.
How to locally test this code change?