Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Enable autoscaling for Compactor #2817

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

7onn
Copy link

@7onn 7onn commented Dec 3, 2023

related issue: #2820

This PR aims to enable autoscaling feature for the compactor workload in tempo-distrubuted Helm Chart.

It implements two autoscaling possibilities, via HPA and/or via ScaledObject.

My motivation came while I was oncall and one alert introduced me to this runbook. Even though I scaled out the workload manually, I couldn't help but to think that it would make sense to scale out this workload based on the metric that triggered the alert as a critical thing. The value commented in the example was copied from here.

How to locally test this code change?

  • Checkout this branch
  • In the values.yaml, enable the autoscaling + keda and/or hpa
    • Replace the empty array for the commented Prometheus trigger
  • Use the commands below to output the manifests
$ cd charts/tempo-distributed
# Check for the Keda ScaledObject output
$ helm -n tempo template tempo . | yq '. | select(.kind == "ScaledObject")' | kubectl diff -f -
# Check for the HPA output
$ helm -n tempo template tempo . | yq '. | select(.kind == "HorizontalPodAutoscaler")' | kubectl diff -f -

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2023

CLA assistant check
All committers have signed the CLA.

@7onn 7onn force-pushed the 7onn/autoscaling-tempo-compactor branch from 2dd7c2c to 690158b Compare December 3, 2023 15:07
@7onn 7onn changed the title [tempo-distributed] Enable autocaling for Compactor [tempo-distributed] Enable autoscaling for Compactor Dec 3, 2023
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
Signed-off-by: Tom M G <devbytom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants