[tempo] fix service labels customization through values #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlowaXD
requested review from
dgzlopes,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
|
BlowaXD
changed the title
Pumba98
approved these changes
Feb 11, 2024
zalegrala
approved these changes
Mar 21, 2024
BlowaXD
force-pushed
the
main
branch
2 times, most recently
from
4314150
to
521db93
Compare
Signed-off-by: Blowa <blowa@olympusgg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
https://github.com/grafana/helm-charts/blob/main/charts/tempo/values.yaml#L258
https://github.com/grafana/helm-charts/blob/main/charts/tempo/README.md?plain=1#L32
I would really appreciate the ability to customize the service labels. however, we found out that the include statement was missing while the value customization is written in the default
values.yaml& README.mdThank you