[tempo-distributed] DOCS fix typos #3027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclegg
requested review from
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
mattclegg
changed the title
krajorama
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Hi @mattclegg,
please review the https://github.com/mattclegg/grafana--helm-charts/blob/DOCS-fix-tempo-distributed/CONTRIBUTING.md guideline. Signing commits is required and also a version bump (on patch level in this case, e.g. 1.9.1->1.9.2), which in turn implies running helm-docs to update the README of the chart.
It's not stated there, but the automation will also refuse PRs that change more than one chart, so I'd advise to move the changes to the tempo chart from #2791 here in this PR.
regards, krajo
please direct mention me (@krajorama ) in reply, otherwise I can miss notifications - I get a tonne
mattclegg
force-pushed
the
DOCS-fix-tempo-distributed
branch
2 times, most recently
from
921b379
to
0dce02d
Compare
|
Ok @krajorama Rebased/signed & cherry-picked relevant changes to this PR. |
Signed-off-by: Matt Clegg <m@cle.gg>
Signed-off-by: Matt Clegg <m@cle.gg>
mattclegg
force-pushed
the
DOCS-fix-tempo-distributed
branch
from
fe1d8a6
to
fdc80ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TYPOs in DOCS