Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Fix HPA selector #3050

Merged
merged 10 commits into from May 7, 2024

Conversation

gritzkoo
Copy link
Contributor

@gritzkoo gritzkoo commented Mar 31, 2024

Previous PR try: #3033

related issues:

Fix the helper to select the correct HPA on kubernetes >=v1.23.

This new select has tested in my local kubernetes development and the right version has selected!

image
image
image
grafana-6.57.0.tgz


I tested on version 6.57.0 in my local but the issue is the same on the latest version.

- grafana#2558
- grafana#2493
- grafana#1391
- grafana#2126

Signed-off-by: Gritzko Daniel Kleiner <ext.gritzko.kleiner@dafiti.com.br>
@gritzkoo gritzkoo force-pushed the hotfix/solve-grafana-hpa-selector branch from 99cd31c to eb62f38 Compare March 31, 2024 14:36
@zanhsieh zanhsieh changed the title Fix HPA selector for grafana helm charts [grafana] Fix HPA selector Mar 31, 2024
charts/grafana/templates/_helpers.tpl Outdated Show resolved Hide resolved
@gritzkoo gritzkoo force-pushed the hotfix/solve-grafana-hpa-selector branch from 6d94096 to eb62f38 Compare April 9, 2024 11:26
@gritzkoo gritzkoo requested a review from zanhsieh April 9, 2024 11:26
gritzkoo and others added 5 commits April 19, 2024 10:28
@zanhsieh
Copy link
Collaborator

zanhsieh commented May 1, 2024

@Xtigyro @zalegrala Can you approve this PR plz?

@zanhsieh zanhsieh merged commit e7a151e into grafana:main May 7, 2024
6 checks passed
kireque added a commit to kireque/home-ops that referenced this pull request May 8, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [grafana](https://grafana.com)
([source](https://togithub.com/grafana/helm-charts)) | patch | `7.3.9`
-> `7.3.10` |

---

### Release Notes

<details>
<summary>grafana/helm-charts (grafana)</summary>

###
[`v7.3.10`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-7.3.10)

[Compare
Source](https://togithub.com/grafana/helm-charts/compare/grafana-7.3.9...grafana-7.3.10)

The leading tool for querying and visualizing time series and metrics.

#### What's Changed

- \[grafana] Fix HPA selector by
[@&#8203;gritzkoo](https://togithub.com/gritzkoo) in
[grafana/helm-charts#3050

#### New Contributors

- [@&#8203;gritzkoo](https://togithub.com/gritzkoo) made their first
contribution in
[grafana/helm-charts#3050

**Full Changelog**:
grafana/helm-charts@tempo-distributed-1.9.9...grafana-7.3.10

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

---------

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Co-authored-by: Kireque <5346530+kireque@users.noreply.github.com>
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request May 8, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [grafana](https://grafana.com)
([source](https://togithub.com/grafana/helm-charts)) | patch | `7.3.9`
-> `7.3.10` |

---

### Release Notes

<details>
<summary>grafana/helm-charts (grafana)</summary>

###
[`v7.3.10`](https://togithub.com/grafana/helm-charts/releases/tag/grafana-7.3.10)

[Compare
Source](https://togithub.com/grafana/helm-charts/compare/grafana-7.3.9...grafana-7.3.10)

The leading tool for querying and visualizing time series and metrics.

#### What's Changed

- \[grafana] Fix HPA selector by
[@&#8203;gritzkoo](https://togithub.com/gritzkoo) in
[grafana/helm-charts#3050

#### New Contributors

- [@&#8203;gritzkoo](https://togithub.com/gritzkoo) made their first
contribution in
[grafana/helm-charts#3050

**Full Changelog**:
grafana/helm-charts@tempo-distributed-1.9.9...grafana-7.3.10

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants