Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (big jump of controller-runtime) and Golang to 1.18 #212

Merged
merged 2 commits into from Apr 12, 2023

Conversation

yorugac
Copy link
Collaborator

@yorugac yorugac commented Apr 5, 2023

This PR includes:

  1. Update of Golang 1.17 → 1.18
  2. Update of main Golang dependencies, including k6 and Kubernetes ones. This is a major jump for quite a few packages since we didn't manage to update properly in a while.
    • Among them is the long overdue update of controller-runtime. If I understood the magic in ⚠ leaderelection: use 'leases' as default resource lock object kubernetes-sigs/controller-runtime#1773 correctly, we need to make the next release with explicit configmapsleases set as is done in this PR. Then at some point in the future™, we can remove that setting to have leases by default.
    • Another noticeable change was around types refactoring, back from v0.7.0 🙈
    • Other code changes are relatively minor, mostly related to the tests and variable names.

@yorugac yorugac changed the title Update Golang and dependencies Update dependencies (big jump of controller-runtime) and Golang to 1.18 Apr 12, 2023
@yorugac yorugac merged commit 15e8a8a into main Apr 12, 2023
9 checks passed
@yorugac yorugac deleted the update-go-and-deps branch April 12, 2023 11:20
@yorugac yorugac mentioned this pull request Oct 13, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant