-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native ESM support #3456
base: master
Are you sure you want to change the base?
Native ESM support #3456
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3456 +/- ##
==========================================
+ Coverage 73.57% 73.58% +0.01%
==========================================
Files 277 276 -1
Lines 20234 20322 +88
==========================================
+ Hits 14887 14954 +67
- Misses 4399 4414 +15
- Partials 948 954 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is still very hackish and tries to preserve every observable behavior possible. This also specifically skips adding support for: 1. dynamic import 2. top level await 3. anything around the internal go modules Which will be added later. Also let us concentrate on making this change as not breaking as possible.
What?
Native support for ESM in k6
Why?
Having native ESM support both allows us to use more goja features and drops our internal babel.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3265