Set working dir to the current one if test is read from stdin #3676
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually the working dir for a given script is set based on it's path. For test from stdin that path is file:///- so it is basically the root folder. With this change this changes to the directory k6 was ran from. This means when you do `cat script.js | k6 run -` the working dir will be the same as if you did `k6 run script.js`. But there is still no way to fix `cat path/to/somewhere/script.js | k6 run -` as k6 can't know where it got it's stdin from. fixes #1462
mstoykov
added
the
breaking change
mstoykov
requested review from
codebien and
joanlopez
and removed request for
a team
It sounds like a nice to have from your point of view. Why? The new behavior sounds like the final solution to me. |
|
@codebien this was mostly just pointing out that this will still not work. Not that I do think that there is a way to do it or that we should do something more. As you see I am closing the issue with the commit and the PR. |
codebien
reviewed
Apr 5, 2024
codebien
approved these changes
Apr 5, 2024
joanlopez
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Usually the working dir for a given script is set based on it's path.
For test from stdin that path is file:///- so it is basically the root folder. With this change this changes to the directory k6 was ran from.
This means when you do
cat script.js | k6 run -the working dir will be the same as if you didk6 run script.js.But there is still no way to fix
cat path/to/somewhere/script.js | k6 run -as k6 can't know where it got it's stdin from.fixes #1462
Why?
Fixing the issue and potentially having less people report it
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
This is marked as breaking change as it changes the behaviour - arguably most people expect the new behaviour, so I expect no users actually depend on the current one.