Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy require support #3694

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Drop legacy require support #3694

wants to merge 3 commits into from

Conversation

mstoykov
Copy link
Collaborator

What?

Completely drop the legacy require support

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.53.0 milestone Apr 19, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 19, 2024 09:42
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 19, 2024 09:42
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.48718% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (requireWarning@0a37d2d). Click here to learn what that means.

❗ Current head e5cf758 differs from pull request most recent head 05d8abf. Consider uploading reports for the commit 05d8abf to get more accurate results

Files Patch % Lines
js/bundle.go 77.77% 2 Missing and 2 partials ⚠️
js/modules/resolution.go 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             requireWarning    #3694   +/-   ##
=================================================
  Coverage                  ?   73.25%           
=================================================
  Files                     ?      275           
  Lines                     ?    20340           
  Branches                  ?        0           
=================================================
  Hits                      ?    14900           
  Misses                    ?     4489           
  Partials                  ?      951           
Flag Coverage Δ
ubuntu 73.25% <79.48%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from requireWarning to master April 22, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants