Ingester: Change log line level and make jitter potentially longer. #10689
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanGuedes
force-pushed
the
improve-flushing-jitter
branch
from
b98ef19 to
967ce57
Compare
DylanGuedes
force-pushed
the
improve-flushing-jitter
branch
from
09fe36e to
3d0fa2f
Compare
slim-bean
reviewed
Sep 22, 2023
pkg/ingester/ingester.go
Outdated
| j := i.cfg.FlushCheckPeriod / 100 | ||
| // Add +/- 50% of flush interval as jitter. | ||
| // The default flush check period is 30s so max jitter will be 15s. | ||
| j := i.cfg.FlushCheckPeriod / 2 |
There was a problem hiding this comment.
I think this feels a bit too aggressive, what about 20% (or / 5)
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…rafana#10689) **What this PR does / why we need it**: - Change our sleep log line from `level=debug` to `level=info` to allow visibility of it without having to change the log line level of distributors as a whole - Make the flush jitter to be 20% of flush check period instead of 1%. This means that, for the default 30s flush check period, the jitter will be at most 6s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
level=debugtolevel=infoto allow visibility of it without having to change the log line level of distributors as a wholeWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR