jsonnet: add memberlist_ring_enabled check condition for consul_config_map #11312
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Trivy scan found the following vulnerabilities:
|
sentoz
changed the title
|
Friends, I would like to consider the issue of adopting this change. |
chaudum
approved these changes
Dec 1, 2023
|
@sentoz Thanks for your contribution! |
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…g_map (grafana#11312) The jsonnet lib should not generate a ConfigMap for consul if you are using memberlist. Fixes grafana#11311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #11311
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdated