operator: Replace deprecated ctrl-runtime cfg with custom package #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
reviewed
Jan 17, 2024
Co-authored-by: Robert Jacob <xperimental@solidproject.de>
xperimental
approved these changes
Jan 18, 2024
periklis
added a commit
to periklis/loki
that referenced
this pull request
Jan 22, 2024
…afana#11678) Co-authored-by: Robert Jacob <rojacob@redhat.com> Co-authored-by: Robert Jacob <xperimental@solidproject.de>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Jan 22, 2024
…afana#11678) Co-authored-by: Robert Jacob <rojacob@redhat.com>
periklis
added a commit
to periklis/loki
that referenced
this pull request
Jan 22, 2024
…afana#11678) Co-authored-by: Robert Jacob <rojacob@redhat.com>
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jan 30, 2024
[release-5.7] LOG-4964: Backport PRs grafana#11678
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jan 30, 2024
[release-5.6] LOG-4964: Backport PRs grafana#11678
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jan 30, 2024
[release-5.8] LOG-4964: Backport PRs grafana#11678, grafana#11232, and grafana#11129
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…afana#11678) Co-authored-by: Robert Jacob <rojacob@redhat.com> Co-authored-by: Robert Jacob <xperimental@solidproject.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following PR removes the dependency to controller-runtime's deprecated
v1alpha1.ControllerManagerConfigurationSpecand accompanying file loading and setup code. As per controller-runtime#895 issue the SIG intends to remove the controller config package and in fact does not maintain it anymore.This is a long due task since the last controller-runtime update in the Loki Operator (See #11232) code base. However, the upcoming k8s and controller-runtime bumps render this task more imminent because controller-runtime
v0.16.x:registerProfiler()inmain.goas perAddMetricsExtraHandlerremoved.v0.28.xWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Please consider this as of now as a soft prerequisite for the following PR because we should align with CCO on
release-4.15at minimum but this requires to bump k8s tov0.28.0:In fact this will be a mandatory prerequisite once we implement the Azure CCO automation because the require CCO types exist only in
release-4.15.Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR