Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix indentation for query_range config #12871

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dploeger
Copy link

@dploeger dploeger commented May 3, 2024

What this PR does / why we need it:

Fixes an indentation problem in the helm configuration for query_range

Special notes for your reviewer:

Checklist

  • [/] Reviewed the CONTRIBUTING.md guide (required)
  • [/] Documentation added
  • Tests updated
  • [/] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [/] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [/] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • [/] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@dploeger dploeger requested a review from a team as a code owner May 3, 2024 09:07
@CLAassistant
Copy link

CLAassistant commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

@dploeger
Copy link
Author

dploeger commented May 3, 2024

I haven't updated the chart tests as they seem to be umaintaned anyways. Should I add a test for this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants