Use DeletePartialMatch()
#2660
Merged
Use DeletePartialMatch()
#2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Thanks for working on this! This PR brings in quite a lot of changes to vendored libraries. Some notes:
github.com/prometheus/client_golang: I checked the changelog and LGTM. I've also reviewed the PR introducing theDeletePartialMatch()function and LGTM. The biggest changes are related to the Go collector and come from this PR.github.com/prometheus/common: change to OAuth2 roundtripper, LGTMgithub.com/prometheus/procfs: I haven't checked changes, shouldn't really affect Mimirgoogle.golang.org/protobuf: checked the changelog, LGTM
Given we're not in a hurry, and given the Prometheus go client 1.13.0 has been released 3 days, we may wait a bit before merging or wait until another maintainer does a review on the changes we're vendoring.
3 tasks
|
@LeviHarrison We merged some of these vendor updates as part of #2758. Can you rebase, please? Then I will merge this PR too. Thanks! |
Signed-off-by: Levi Harrison <git@leviharrison.dev>
LeviHarrison
force-pushed
the
use-delete-partial-match
branch
from
ef261a5
to
a537363
Compare
|
Rebased 👍🏻 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Switches from Mimir's own
DeleteMatchingLabels()to client_golang's newDeletePartialMatch().Which issue(s) this PR fixes or relates to
Fixes #1764
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]