Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alpine/helm from 3.11.1 to 3.13.0 in /mimir-build-image #6188

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Oct 2, 2023

https://github.com/grafana/mimir/pull/6180/files update build-image failed because bug of docker/login-action@v3, there is a similar ticket opened in repo docker/login-action#606, fallback github action downgrade to docker/login-action v2 to unblock docker image update.

See failed build #6180

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

dependabot bot and others added 2 commits October 2, 2023 11:30
Bumps alpine/helm from 3.11.1 to 3.13.0.

---
updated-dependencies:
- dependency-name: alpine/helm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6188-f9147daefa`. This can take up to 1 hour.

@ying-jeanne ying-jeanne marked this pull request as ready for review October 2, 2023 11:52
@ying-jeanne ying-jeanne requested a review from a team as a code owner October 2, 2023 11:52
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting a comment for the downgrade.

.github/workflows/push-mimir-build-image.yml Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Not building new version of mimir-build-image. This PR modifies `mimir-build-image/Dockerfile`, but the image `grafana/mimir-build-image:pr6188-f9147daefa` already exists.

@aknuds1 aknuds1 added the chore label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Not building new version of mimir-build-image. This PR modifies `mimir-build-image/Dockerfile`, but the image `grafana/mimir-build-image:pr6188-f9147daefa` already exists.

@aknuds1 aknuds1 enabled auto-merge (squash) October 2, 2023 12:49
@aknuds1 aknuds1 merged commit 105bb2c into main Oct 2, 2023
29 checks passed
@aknuds1 aknuds1 deleted the my-new-branch branch October 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants