query-frontend: add experimental header for tracking throughput #7966
+266
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/frontend/transport/handler.go
Outdated
| @@ -62,6 +64,7 @@ func (cfg *HandlerConfig) RegisterFlags(f *flag.FlagSet) { | |||
| f.Var(&cfg.LogQueryRequestHeaders, "query-frontend.log-query-request-headers", "Comma-separated list of request header names to include in query logs. Applies to both query stats and slow queries logs.") | |||
| f.Int64Var(&cfg.MaxBodySize, "query-frontend.max-body-size", 10*1024*1024, "Max body size for downstream prometheus.") | |||
| f.BoolVar(&cfg.QueryStatsEnabled, "query-frontend.query-stats-enabled", true, "False to disable query statistics tracking. When enabled, a message with some statistics is logged for every query.") | |||
| f.BoolVar(&cfg.ExtraQueryStatsHeaders, "query-frontend.extra-stats-headers", false, "Add extra query stats headers to the response.") | |||
There was a problem hiding this comment.
is there a drawback to always returning the header?
There was a problem hiding this comment.
hmm, not really, but this is super experimental, don't want people to depend on it
There was a problem hiding this comment.
Same comment as Dimitar. You can just document it as experimental in about-version and we're good.
pkg/frontend/transport/handler.go
Outdated
| @@ -448,6 +454,12 @@ func writeServiceTimingHeader(queryResponseTime time.Duration, headers http.Head | |||
| } | |||
| } | |||
|
|
|||
| func writeStatsHeader(headers http.Header, stats *querier_stats.Stats) { | |||
| if stats != nil { | |||
| headers.Set(MimirQueryStatsHeaderName, fmt.Sprintf("fetched_chunk_bytes=%d", stats.GetFetchedChunkBytes())) | |||
There was a problem hiding this comment.
The stats are modified using atomics - so they should be read with:
mimir/pkg/querier/stats/stats.go
Line 86 in e238310
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/samples-loaded-header
branch
from
83f4820
to
f216056
Compare
|
Rebased and removed the flag. Next: change to track samples loaded. |
We'll use this instead of chunks bytes as it is simpler for the enduser to understand. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
force-pushed
the
krajo/samples-loaded-header
branch
from
75e398b
to
186306e
Compare
krajorama
added a commit
to krajorama/prometheus
that referenced
this pull request
May 18, 2024
defaultStatsRenderer->DefaultStatsRenderer Add short docstrings. I'd like to use the stats renderer to peek at the statistics in grafana/mimir#7966 However I cannot call the original function without this export afterwards. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added a commit
to prometheus/prometheus
that referenced
this pull request
May 18, 2024
defaultStatsRenderer->DefaultStatsRenderer Add short docstrings. I'd like to use the stats renderer to peek at the statistics in grafana/mimir#7966 However I cannot call the original function without this export afterwards. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add an experimental configuration parameter
-query-frontend.extra-stats-headersto be able to send fetched chunk bytes to the gateway for measuring throughput.Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.