Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming PromQL engine: benchmarking improvements #8114

Merged

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR makes two small changes to the benchmarking setup for the streaming PromQL engine:

  • The Prometheus engine is now referred to consistently by that name, rather than sometimes as the "standard" engine
  • tools/benchmark-query-engine can now start the ingester used for benchmarks and run it continuously, so multiple invocations of tools/benchmark-query-engine can use the same ingester. This means we can avoid waiting to load data into the ingester on each run of tools/benchmark-query-engine, which takes about a minute on my machine.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • [n/a] Tests updated.
  • [n/a] Documentation added.
  • [n/a] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review May 13, 2024 05:44
@charleskorn charleskorn requested a review from a team as a code owner May 13, 2024 05:44
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
(the capitalisation of Prometheus and not streaming bothers me, but I understand why :-p)

@charleskorn charleskorn merged commit 1d4aac1 into main May 13, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/streaming-promql-benchmarking-improvements branch May 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants