Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditionally enable searching for alert groups via env var #4287

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

conditionally enable searching for alert groups via env var #4287

wants to merge 11 commits into from
+8 −1

Conversation

sreway
Copy link
Contributor

@sreway sreway commented Apr 26, 2024 •
edited by joeyorlando

What this PR does

re-enables the search for alert groups

Which issue(s) this PR closes

Closes #2232

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@sreway sreway requested review from a team as code owners April 26, 2024 11:46
@fantom0005
Copy link

Could you please add this solution to Incident's Public API?
I mean there https://github.com/grafana/oncall/blob/dev/engine/apps/public_api/views/incidents.py#L37.

If it is possible

joeyorlando
joeyorlando approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thank you for your contribution @sreway!

grafana-plugin/src/models/alertgroup/alertgroup.ts Outdated Show resolved Hide resolved
@joeyorlando joeyorlando changed the title enable searching for alert groups conditionally enable searching for alert groups Apr 26, 2024
@joeyorlando joeyorlando changed the title conditionally enable searching for alert groups conditionally enable searching for alert groups via env var Apr 26, 2024
@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Apr 26, 2024
@joeyorlando
Copy link
Collaborator

@sreway if you don't mind address the linting CI errors I can go ahead and merge this! (run pre-commit run --all-files locally)

sreway and others added 2 commits April 27, 2024 13:02
@sreway @joeyorlando
update alertgroup query
dc23411 
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
@sreway
lint
78dbb82
@sreway
Copy link
Contributor Author

sreway commented Apr 27, 2024

Could you please add this solution to Incident's Public API? I mean there https://github.com/grafana/oncall/blob/dev/engine/apps/public_api/views/incidents.py#L37.

If it is possible

This solution will not work with the public API. You can create a feature request to extend the filtering of alert groups.

@joeyorlando joeyorlando requested a review from maskin25 May 13, 2024 17:14
@joeyorlando
Copy link
Collaborator

@maskin25 are things okay from your point of view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

@maskin25 maskin25 Awaiting requested review from maskin25

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

re-enable free-text searching on alert groups
5 participants
@sreway @fantom0005 @joeyorlando @maskin25 @iskhakov