Schedule two-weeks and monthly view #4318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskin25
added
involved:Frontend
release:enhancement
maskin25
added
the
pr:no public docs
maskin25
changed the title
teodosii
reviewed
May 24, 2024
| // wait until a scroll to the "Rotations" happened | ||
| setTimeout(() => { | ||
| setIsOpen(true); | ||
| }, 100); |
There was a problem hiding this comment.
Why do we need to wait for a scroll to happen on Rotations Form? Maybe add a comment to indicate the reason? Seems very hackish, is it guaranteed to work all the times for 100ms?
teodosii
reviewed
May 24, 2024
| @@ -18,6 +18,10 @@ export const waitForElement = (selector: string) => { | |||
| }); | |||
| }; | |||
|
|
|||
| export const scrollToElement = (element: Element, behavior: ScrollBehavior = 'instant' as ScrollBehavior) => { | |||
| document.getElementById('rotations').scrollIntoView({ behavior, block: 'center' }); | |||
There was a problem hiding this comment.
this should use the element instead, right?
teodosii
reviewed
May 24, 2024
| @@ -100,27 +101,25 @@ class _Rotations extends Component<RotationsProps, RotationsState> { | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className={cx('root')}> | |||
| <div id="rotations" className={cx('root')}> | |||
There was a problem hiding this comment.
Can we namepsace these ids to be part of grafana oncall only maybe? Or even better, could we instead access these elements through refs so that we don't use ids?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Update layers visualisation
Which issue(s) this PR closes
https://github.com/grafana/oncall-private/issues/2667
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.