feat(godeltaprof): service info mapping injection #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jan 18, 2024
| ) | ||
|
|
||
| const ( | ||
| LabelNameServiceRepository = "service_repository" |
There was a problem hiding this comment.
I don't think you need this.
There was a problem hiding this comment.
I was going to add both mapping and labels in one PR, but decided to separate
There was a problem hiding this comment.
It looks like only heap, mutex, and block profiles will have version info embedded into mapping.BuildID. Are we going to do same with CPU and goroutine profiles?
I'm wondering if we do really need/want to inject the version information into mappings:
- Use of static labels is probably the most straight forward and convenient way for push mode.
- In pull mode, we could implement a generic mechanism of metadata propagation through the HTTP response headers. Grafana Agent could extract the headers and inject them as series labels.
|
I like headers idea much more than the current PR mapping implementation. @cyriltovena wdyt ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.