Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject tokens on global-scoped resources #1421

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

julienduchesne
Copy link
Member

Closes #1402
This checks that resources that manage global scoped things will throw an easy to understand error message if TF users try to use an org-scoped token

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne force-pushed the julienduchesne/global-token-validation branch from 3ed44f9 to 2b5c8f2 Compare March 14, 2024 15:43
@julienduchesne julienduchesne marked this pull request as ready for review March 14, 2024 16:01
@julienduchesne julienduchesne requested a review from a team as a code owner March 14, 2024 16:01
@julienduchesne julienduchesne changed the title Add token validation on global-scoped resources Reject tokens on global-scoped resources Mar 14, 2024
@julienduchesne julienduchesne force-pushed the julienduchesne/global-token-validation branch from 2b5c8f2 to 96d24c5 Compare March 28, 2024 12:28
Closes #1402
This checks that resources that manage global scoped things will throw an easy to understand error message if TF users try to use an org-scoped token
@julienduchesne julienduchesne force-pushed the julienduchesne/global-token-validation branch from 8e3024c to 7eeded4 Compare March 28, 2024 13:56
@julienduchesne julienduchesne merged commit dc97bb6 into main Mar 28, 2024
27 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/global-token-validation branch March 28, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add a clear error when an instance level resource (not org) is being managed with a token
2 participants