SM: Use common resource framework #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
requested review from
roobre and
The-9880
and removed request for
a team
julienduchesne
force-pushed
the
julienduchesne/sm-framework
branch
from
cb7e285
to
2b5fa56
Compare
julienduchesne
added a commit
that referenced
this pull request
Mar 24, 2024
Same as #1433 Paving the way for TF code generation However, this one was special because it required some modifications to the framework: Adding optional fields to IDs This was work that I expected I would have to do for Grafana resources anyways, since most Grafana resources have the optional orgID field that can be used in imports
julienduchesne
force-pushed
the
julienduchesne/sm-framework
branch
from
2b5fa56
to
9910c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1433
Paving the way for TF code generation
However, this one was special because it required some modifications to the framework: Adding optional fields to IDs
This was work that I expected I would have to do for Grafana resources anyways, since most Grafana resources have the optional orgID field that can be used in imports