-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grafana_data_source_config
resource
#1441
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Nice, thanks for picking this up. Some things need fixing but this is a good start |
@julienduchesne I fixed all comments but the one related to the common code extraction. I understand its idea, but couldn't find an idiomatic way to do so. I'm still happy to do it if you give me an example. |
I can take a look 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test, fixed up a few things and make a bunch of code common between the regular datasource resource. LGTM now! Thank you!
This PR introduces the
grafana_data_source_config
resource. It will separate the creation of the Data Source from its configuration. This is especially useful in cases where multiple Data Sources configurations depend on each other, thus creating a circular dependency.Closes #1408