Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grafana_data_source_config resource #1441

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

miljanic
Copy link
Contributor

This PR introduces the grafana_data_source_config resource. It will separate the creation of the Data Source from its configuration. This is especially useful in cases where multiple Data Sources configurations depend on each other, thus creating a circular dependency.

Closes #1408

@miljanic miljanic requested a review from a team as a code owner March 22, 2024 23:59
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne
Copy link
Member

Nice, thanks for picking this up. Some things need fixing but this is a good start

@miljanic
Copy link
Contributor Author

@julienduchesne I fixed all comments but the one related to the common code extraction. I understand its idea, but couldn't find an idiomatic way to do so. I'm still happy to do it if you give me an example.

@julienduchesne
Copy link
Member

@julienduchesne I fixed all comments but the one related to the common code extraction. I understand its idea, but couldn't find an idiomatic way to do so. I'm still happy to do it if you give me an example.

I can take a look 👀

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test, fixed up a few things and make a bunch of code common between the regular datasource resource. LGTM now! Thank you!

@julienduchesne julienduchesne merged commit 1dc36b2 into grafana:main Mar 27, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: grafana_data_source data allow non-existing datasource
3 participants