Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeepLast to NoDataState & ExecErrState in Alerting Rule Group #1442

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Add KeepLast to NoDataState & ExecErrState in Alerting Rule Group #1442

merged 1 commit into from
Mar 25, 2024

Conversation

Cleymax
Copy link
Contributor

@Cleymax Cleymax commented Mar 23, 2024

@Cleymax Cleymax requested review from a team as code owners March 23, 2024 19:45
@github-actions GitHub Actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@Cleymax
Copy link
Contributor Author

Cleymax commented Mar 23, 2024

Add ValidateFunc for these 2 attributes?

@julienduchesne
Copy link
Member

LGTM. It's validated by the API 🤷

@julienduchesne julienduchesne merged commit eac8b1a into grafana:main Mar 25, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cleymax @julienduchesne