Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grafana_data_source_permission_item #1470

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Implement grafana_data_source_permission_item #1470

merged 1 commit into from
Apr 10, 2024

Conversation

julienduchesne
Copy link
Member

Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne force-pushed the julienduchesne/ds-permission-item branch 2 times, most recently from 9bfb0ce to b34447f Compare April 5, 2024 19:03
@julienduchesne julienduchesne marked this pull request as ready for review April 5, 2024 19:03
@julienduchesne julienduchesne requested a review from a team as a code owner April 5, 2024 19:03
@julienduchesne julienduchesne force-pushed the julienduchesne/ds-permission-item branch from b34447f to 39e09a2 Compare April 5, 2024 19:55
julienduchesne added a commit that referenced this pull request Apr 8, 2024
@julienduchesne
Permission Items: Common code
771aea6 
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add
@julienduchesne julienduchesne mentioned this pull request Apr 8, 2024
Merged
@julienduchesne julienduchesne reopened this Apr 8, 2024
Base automatically changed from julienduchesne/folder-permission-item to main April 10, 2024 12:34
@julienduchesne
Implement grafana_data_source_permission_item
2cbc58c 
Part of #1000
Built on top of #1465

Lots of common code between these two PRs but I'll make a lot of it common in a future PR. There is still the dashboards and service account permissions to implement
@julienduchesne julienduchesne force-pushed the julienduchesne/ds-permission-item branch from 39e09a2 to 2cbc58c Compare April 10, 2024 12:35
@julienduchesne julienduchesne merged commit cebd643 into main Apr 10, 2024
27 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/ds-permission-item branch April 10, 2024 13:28
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Permission Items: Common code
09e7b9c 
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add
julienduchesne added a commit that referenced this pull request Apr 10, 2024
@julienduchesne
Permission Items: Common code (#1471)
549e3e2 
* Permission Items: Common code
Follow-up to #1465 and #1470
Lots of the code is exactly the same since it's the same API. This PR puts it in a common struct so that other permissions resources will be easier to add

* Framework doesn't support generic models

* Fix resourceType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Phoen K-Phoen K-Phoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julienduchesne @K-Phoen