Permission resources: Common code #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
julienduchesne
force-pushed
the
julienduchesne/permission-common-code
branch
4 times, most recently
from
291bfad
to
1568bc0
Compare
Current situation: - Folder and datasource permissions have copy pasted code and same API - Service account permissions has the same API as the previous two resources, but different code - Dashboard permissions use a deprecated API This PR brings all of the resource's code into a common helper.
julienduchesne
force-pushed
the
julienduchesne/permission-common-code
branch
from
1568bc0
to
7d2649a
Compare
K-Phoen
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation:
This PR brings all of the resource's code into a common helper