TestAccExampleWithReplace: Make sure replace is actually done
#1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test function replaces strings in test configs, but nothing actually ensures that the resulting config is what we expect If a string doesn't exist it will be a no-op This PR should help debug cases where this happens
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
malcolmholmes
approved these changes
Apr 15, 2024
julienduchesne
requested review from
roobre and
The-9880
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test function replaces strings in test configs, but nothing actually ensures that the resulting config is what we expect: If a string doesn't exist it will be a no-op
This PR should help debug cases where this happens