Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oncall_schedule.md #1513

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Update oncall_schedule.md #1513

merged 2 commits into from
Apr 26, 2024

Conversation

gthompson280
Copy link
Contributor

The Schedule HTTP API docs (https://grafana.com/docs/oncall/latest/oncall-api-reference/schedules/) that the oncall_schedule resource uses specify "web" as a valid type value.

However, this isn't an available option for the TF resource due to drift or conflict issues. It would be good to clarify the valid values ("ical" and "calendar") since this differs from the Schedule HTTP API docs.

The Schedule HTTP API docs (https://grafana.com/docs/oncall/latest/oncall-api-reference/schedules/) that the oncall_schedule resource uses specify "web" as a valid type value.

However, this isn't an available option for the TF resource due to drift or conflict issues. It would be good to clarify the available values ("ical" and "calendar") since this differs from the Schedule HTTP API docs.
@gthompson280 gthompson280 requested a review from a team as a code owner April 25, 2024 22:14
@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@gthompson280 gthompson280 requested a review from a team as a code owner April 26, 2024 19:34
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@julienduchesne julienduchesne merged commit a565e6e into main Apr 26, 2024
27 checks passed
@julienduchesne julienduchesne deleted the gthompson280-patch-1 branch April 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants