Datasources: Fix numerical UIDs #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1511 The current `getDatasourceByUIDOrID` logic does not support numerical UIDs Since the ID of the resource is now normalized, we should always start with trying the ID as a DS UID, and if that fails, try it as a numerical ID
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
K-Phoen
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1511
The current
getDatasourceByUIDOrIDlogic does not support numerical UIDsSince the ID of the resource is now normalized, we should always start with trying the ID as a DS UID, and if that fails, try it as a numerical ID