adds dep + options for debugger #35
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm honestly all for it, maybe we could use an environment variable or something? System property? But it depends if the license is compatible tbh |
wagyourtail
reviewed
Jul 31, 2022
| public static final Engine engine = Engine.newBuilder().option("engine.WarnInterpreterOnly", "false").build(); | ||
| public static final Engine engine = Engine.newBuilder() | ||
| .option("engine.WarnInterpreterOnly", "false") | ||
| .option("inspect", "localhost:9229") |
There was a problem hiding this comment.
might be a good idea to make this some kind of config option, iirc the inspect thing halts js until a debugger is attached
There was a problem hiding this comment.
iirc the inspect thing halts js until a debugger is attached
Yea, it does. I haven't messed with it too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do Not Merge
This is a showcase for debugging.
However, I do recommend we establish a way of supporting this feature within Grakkit and allowing the user to enable the feature as needed for their use case.