New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to vuepress-vite #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Please update the docsearch dependency to beta.27 so that it's in sync with vuepress-vite
.
@KnorpelSenf Already update docsearch to newest. |
@WingLim Why did this PR downgrade the lockfile version to |
Oops, I check my mac using |
It looks like vite has a rendering bug that affects us. It may make sense to migrate back to webpack for now, and to go back to vite once they fixed it. Please have a look at this: vuepress/core#602 (comment) |
@roj1512 instead, we could try to rephrase the paragraph at https://grammy.dev/guide/basics.html#sending-messages-with-reply so that it no longer is affected by the bug. What is your opinion on this? @WingLim what is yours? |
Yet another alternative would be to hard-code an exception for the respective paragraph in the We could revert this change once vuepress/core#602 is fixed. |
Can we know how many places are affected by this bug in the document website? |
I believe it's only the single paragraph that I linked. I read the complete docs. |
Let's see what's @roj1512 option, I prefer the second(the hard-core one), |
@KnorpelSenf I am not seeing any duplicate text on the guide/basics page when I run locally. |
That's part of the bug. This behaviour is described in the aforementioned issue. |
How should it get rephrased btw? Get the text out of quotes? |
I don't think it's happening only in quotes, does it? We'll just have to play a bit around with it until it suddenly doesn't appear anymore. That is, unless you want to understand the bug, but at that point you might as well fix vuepress. |
Closes #49.