Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to vuepress-vite #50

Merged
merged 2 commits into from Nov 2, 2021
Merged

feat: migrate to vuepress-vite #50

merged 2 commits into from Nov 2, 2021

Conversation

WingLim
Copy link
Collaborator

@WingLim WingLim commented Nov 2, 2021

Closes #49.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please update the docsearch dependency to beta.27 so that it's in sync with vuepress-vite.

@WingLim
Copy link
Collaborator Author

WingLim commented Nov 2, 2021

@KnorpelSenf Already update docsearch to newest.

@WingLim WingLim merged commit 2b0f7f2 into main Nov 2, 2021
@WingLim WingLim deleted the feat/vuepress-vite branch November 2, 2021 09:34
@KnorpelSenf
Copy link
Member

@WingLim Why did this PR downgrade the lockfile version to 1?

@WingLim
Copy link
Collaborator Author

WingLim commented Nov 3, 2021

@WingLim Why did this PR downgrade the lockfile version to 1?

Oops, I check my mac using pnpm to manage node version.
node and npm switch back to old version, and I didn't notice it.
Will upgrade it back...

@KnorpelSenf
Copy link
Member

It looks like vite has a rendering bug that affects us. It may make sense to migrate back to webpack for now, and to go back to vite once they fixed it. Please have a look at this: vuepress/core#602 (comment)

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Apr 5, 2022

@roj1512 instead, we could try to rephrase the paragraph at https://grammy.dev/guide/basics.html#sending-messages-with-reply so that it no longer is affected by the bug. What is your opinion on this? @WingLim what is yours?

@KnorpelSenf
Copy link
Member

Yet another alternative would be to hard-code an exception for the respective paragraph in the <wbr> tag injection plugin. I am not too convinced that this is the right thing to do, but it would certainly work.

We could revert this change once vuepress/core#602 is fixed.

@WingLim
Copy link
Collaborator Author

WingLim commented Apr 5, 2022

It looks like vite has a rendering bug that affects us. It may make sense to migrate back to webpack for now, and to go back to vite once they fixed it. Please have a look at this: vuepress/vuepress-next#602 (comment)

Can we know how many places are affected by this bug in the document website?

@KnorpelSenf
Copy link
Member

I believe it's only the single paragraph that I linked. I read the complete docs.

@WingLim
Copy link
Collaborator Author

WingLim commented Apr 5, 2022

I believe it's only the single paragraph that I linked. I read the complete docs.

Let's see what's @roj1512 option, I prefer the second(the hard-core one), vite is faster for dev in preview.

@roj1512
Copy link
Member

roj1512 commented Apr 5, 2022

@KnorpelSenf I am not seeing any duplicate text on the guide/basics page when I run locally.

@KnorpelSenf
Copy link
Member

That's part of the bug. This behaviour is described in the aforementioned issue.

@roj1512
Copy link
Member

roj1512 commented Apr 5, 2022

How should it get rephrased btw? Get the text out of quotes?

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Apr 6, 2022

I don't think it's happening only in quotes, does it? We'll just have to play a bit around with it until it suddenly doesn't appear anymore. That is, unless you want to understand the bug, but at that point you might as well fix vuepress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: migrate vuepress to vuepress-vite or vitepress
3 participants