Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop timer when it's no longer needed #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stop timer when it's no longer needed #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion dataloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,12 +481,14 @@ func (b *batcher[K, V]) batch(originalContext context.Context) {

// wait the appropriate amount of time for the provided batcher
func (l *Loader[K, V]) sleeper(b *batcher[K, V], close chan bool) {
timer := time.NewTimer(l.wait)
select {
// used by batch to close early. usually triggered by max batch size
case <-close:
timer.Stop()
return
// this will move this goroutine to the back of the callstack?
case <-time.After(l.wait):
case <-timer.C:
}

// reset
Expand Down