chore(deps): try supporting GraphQL v16 #764
Conversation
|
Why do you need to support EOL versions of Node.js? |
|
I agree; and will be officially and explicitly not supporting EOL versions of Node, Postgres, GraphQL, etc from V5 onwards. However this was not stated in the V4.0.0 release and I want to stay within semver which is somewhat fuzzy on the topic but there has definitely been pushback on removing support. |
|
It looks like |
|
Is there anything I can do to help with this migration / what is the state of it right now? |
|
According to the GraphQL.js WG yesterday a fix to the above issue is being worked on. Please follow that thread linked above. |
|
|
|
Any chance we can get an update on this? It's a major blocker for several down stream packages. Thanks. |
|
Rebased, GraphQL version bumped in the lockfile, added a few type workarounds. Fingers crossed 🤞 |
|
Alas, more work is required to support V16 without breaking backwards compatibility with previously supported versions of GraphQL. My time is currently focussed on developing PostGraphile V5, but if you wanted to raise a PR against this PR to make the necessary changes you're welcome to - I suspect it's mostly signature changes on the various methods where object parameters are now required instead of positional arguments. I don't personally see this as much of a priority because it's still perfectly reasonable to use GraphQL v15 and there's no features in v16 that PostGraphile v4 needs. If I'm missing something, please feel free to let me know what critical reasons there are for using GraphQL v16 rather than v15 👍 |
|
I agree with you, let's focus on PostGraphile V5. We just fine, sometime the npm install auto upgrade cause we frustrated and then the feeling of everything perfect make us need the new version must be up to date, but after all it just fine. haha |
|
If you need GraphQL v16 support, use PostGraphile V5 👍 |
GraphQL v16 doesn't support Node 8 or Node 10 or older versions of Node 12, so we cannot merge all of this, I'm opening it primarily to see if CI will pass on Node 12+.
Fixes #773