feat: make bridge tasks prettier and display more info for L2 to L1 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #783 +/- ##
==========================================
+ Coverage 91.59% 92.60% +1.01%
==========================================
Files 42 47 +5
Lines 1999 2368 +369
Branches 361 432 +71
==========================================
+ Hits 1831 2193 +362
- Misses 168 175 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
pcarranzav
reviewed
Jan 25, 2023
tasks/bridge/deposits.ts
Outdated
| @@ -37,6 +37,11 @@ task(TASK_BRIDGE_DEPOSITS, 'List deposits initiated on L1GraphTokenGateway') | |||
| `Tracking 'DepositFinalized' events on L2GraphTokenGateway (${l2Gateway.address}) from block ${l2StartBlock} onwards`, | |||
| ) | |||
|
|
|||
| const amount = await ( | |||
There was a problem hiding this comment.
did you add this additional query on purpose? if so, it might be better to store the result and use it for depositInitiatedEvents below?
But also, isn't it this redundant with what's printed on line 73?
pcarranzav
previously approved these changes
Jan 27, 2023
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Signed-off-by: Tomás Migone tomas@edgeandnode.com