Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove minimum allocation duration restriction #902

Merged
merged 7 commits into from May 13, 2024
Merged

feat: remove minimum allocation duration restriction #902

merged 7 commits into from May 13, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jan 4, 2024 •
edited

Implementation for https://forum.thegraph.com/t/gip-0060-early-allocation-closure/4559

Changes

  • Staking contract no longer has a minimum duration requirement of one epoch. Allocations can be opened and closed within the same epoch.
  • Allocations that are closed less than one epoch after they were opened will not get indexing rewards even with a valid POI.
  • Indexers should still use 0x00 POI to close allocations opened by mistake, or for subgraphs that were not synced, etc.

@tmigone
feat: remove minium allocation duration restriction
0a7dca8 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 4, 2024 •
edited

feat: remove minimum allocation duration restriction

Generated at commit: 08dcc6aa46baef82ae386a3f369645ad72aed667

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
37
58
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (59154f7) to head (08dcc6a).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   92.70%   92.69%   -0.01%     
==========================================
  Files          46       46              
  Lines        2370     2369       -1     
  Branches      426      425       -1     
==========================================
- Hits         2197     2196       -1     
  Misses        173      173
Flag Coverage Δ
unittests 92.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone changed the title feat: remove minium allocation duration restriction feat: remove minimum allocation duration restriction Jan 4, 2024
Maikol
Maikol previously approved these changes Jan 5, 2024
View reviewed changes
pcarranzav
pcarranzav previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@tmigone tmigone dismissed stale reviews from pcarranzav and Maikol via 54af1a7 March 18, 2024 13:21
@tmigone
chore: add audit report
ec3c7cd 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
fix(test): assert that no rewards are issued on early allocation closure
bbdea62 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: update addressbook with testnet deployment
2663ae3 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore: update arbitrum addresses with new staking implementation
d0722b3 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@tmigone
chore(contracts): bump package version
08dcc6a 
Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/util-utf8-browser@3.259.0 None 0 20 kB aws-sdk-bot
npm/@babel/compat-data@7.24.4 None 0 65.2 kB nicolo-ribaudo
npm/@babel/core@7.24.5 environment, filesystem, unsafe +1 850 kB nicolo-ribaudo
npm/@babel/generator@7.24.5 None 0 493 kB nicolo-ribaudo
npm/@babel/helper-annotate-as-pure@7.22.5 None 0 4.02 kB nicolo-ribaudo
npm/@babel/helper-create-class-features-plugin@7.24.5 None 0 502 kB nicolo-ribaudo
npm/@babel/helper-environment-visitor@7.22.20 None 0 6.56 kB nicolo-ribaudo
npm/@babel/helper-function-name@7.23.0 None 0 21.6 kB nicolo-ribaudo
npm/@babel/helper-hoist-variables@7.22.5 None 0 7.03 kB nicolo-ribaudo
npm/@babel/helper-member-expression-to-functions@7.24.5 None 0 107 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.3 None 0 63.8 kB nicolo-ribaudo
npm/@babel/helper-module-transforms@7.24.5 None 0 158 kB nicolo-ribaudo
npm/@babel/helper-optimise-call-expression@7.22.5 None 0 6.66 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.5 None 0 130 kB nicolo-ribaudo
npm/@babel/helper-replace-supers@7.24.1 None 0 32.2 kB nicolo-ribaudo
npm/@babel/helper-simple-access@7.24.5 None 0 14.1 kB nicolo-ribaudo
npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5 None 0 5.96 kB nicolo-ribaudo
npm/@babel/helper-split-export-declaration@7.24.5 None 0 10.7 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.1 None 0 31.7 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.23.5 None 0 11.7 kB nicolo-ribaudo
npm/@babel/helpers@7.24.5 None 0 650 kB nicolo-ribaudo
npm/@babel/parser@7.24.5 None 0 1.89 MB nicolo-ribaudo
npm/@babel/plugin-proposal-class-properties@7.18.6 None 0 3.34 kB nicolo-ribaudo
npm/@babel/plugin-syntax-class-properties@7.12.13 None 0 2.68 kB nicolo-ribaudo
npm/@babel/plugin-syntax-jsx@7.24.1 None 0 4.14 kB nicolo-ribaudo
npm/@babel/plugin-syntax-object-rest-spread@7.8.3 None 0 2.53 kB nicolo-ribaudo
npm/@babel/plugin-transform-arrow-functions@7.24.1 None 0 5.55 kB nicolo-ribaudo
npm/@babel/plugin-transform-block-scoped-functions@7.24.1 None 0 6.55 kB nicolo-ribaudo
npm/@babel/plugin-transform-block-scoping@7.24.5 None 0 155 kB nicolo-ribaudo
npm/@babel/plugin-transform-classes@7.24.5 None 0 160 kB nicolo-ribaudo
npm/@babel/plugin-transform-computed-properties@7.24.1 None 0 22.7 kB nicolo-ribaudo
npm/@babel/plugin-transform-destructuring@7.24.5 None 0 148 kB nicolo-ribaudo
npm/@babel/plugin-transform-for-of@7.24.1 None 0 44.7 kB nicolo-ribaudo
npm/@babel/plugin-transform-function-name@7.24.1 None 0 6.2 kB nicolo-ribaudo
npm/@babel/plugin-transform-literals@7.24.1 None 0 4.63 kB nicolo-ribaudo
npm/@babel/plugin-transform-member-expression-literals@7.24.1 None 0 4.94 kB nicolo-ribaudo
npm/@babel/plugin-transform-modules-commonjs@7.24.1 None 0 42.4 kB nicolo-ribaudo
npm/@babel/plugin-transform-object-super@7.24.1 None 0 9.23 kB nicolo-ribaudo
npm/@babel/plugin-transform-parameters@7.24.5 None 0 132 kB nicolo-ribaudo
npm/@babel/plugin-transform-property-literals@7.24.1 None 0 4.72 kB nicolo-ribaudo
npm/@babel/plugin-transform-react-display-name@7.24.1 None 0 12.4 kB nicolo-ribaudo
npm/@babel/plugin-transform-react-jsx@7.23.4 None 0 80 kB nicolo-ribaudo
npm/@babel/plugin-transform-shorthand-properties@7.24.1 None 0 7.11 kB nicolo-ribaudo
npm/@babel/plugin-transform-spread@7.24.1 None 0 21.2 kB nicolo-ribaudo
npm/@babel/plugin-transform-template-literals@7.24.1 None 0 15.9 kB nicolo-ribaudo
npm/@babel/template@7.24.0 None 0 68.9 kB nicolo-ribaudo
npm/@babel/traverse@7.24.5 None 0 618 kB nicolo-ribaudo
npm/@babel/types@7.24.5 environment 0 2.41 MB nicolo-ribaudo
npm/@cspotcode/source-map-support@0.8.1 filesystem +1 194 kB cspotcode
npm/@eslint-community/eslint-utils@4.4.0 None 0 379 kB eslint-community-bot
npm/@eslint-community/regexpp@4.10.0 None 0 431 kB eslint-community-bot
npm/@fastify/busboy@2.1.1 None 0 80.2 kB gurgunday
npm/@graphql-typed-document-node/core@3.2.0 None 0 2.96 kB dotansimha
npm/@humanwhocodes/module-importer@1.0.1 unsafe 0 21.2 kB nzakas
npm/@humanwhocodes/object-schema@2.0.3 None 0 23.3 kB nzakas
npm/@isaacs/cliui@8.0.2 None +4 67.1 kB isaacs
npm/@ljharb/through@2.3.13 None 0 31.7 kB ljharb
npm/@pkgjs/parseargs@0.11.0 None 0 74.2 kB oss-bot
npm/@sindresorhus/is@0.14.0 None 0 40.2 kB sindresorhus
npm/@smithy/types@2.12.0 None 0 233 kB smithy-team
npm/@types/debug@4.1.12 None 0 6.45 kB types
npm/@types/eslint@8.56.10 None 0 192 kB types
npm/@types/estree@1.0.5 None 0 25.7 kB types
npm/@types/glob@7.2.0 None 0 6.61 kB types
npm/@types/json-schema@7.0.15 None 0 31.7 kB types
npm/@types/minimatch@5.1.2 None 0 12.5 kB types
npm/@types/ms@0.7.34 None 0 3.2 kB types
npm/@types/parse-json@4.0.2 None 0 2.95 kB types
npm/@types/through@0.0.33 None 0 3.43 kB types
npm/@types/yargs-parser@21.0.3 None 0 8.65 kB types
npm/@types/yargs@16.0.9 None 0 53 kB types
npm/@typescript-eslint/types@6.21.0 None 0 156 kB jameshenry
npm/@ungap/structured-clone@1.2.0 None 0 26.2 kB webreflection
npm/acorn-jsx@5.3.2 None 0 24.4 kB rreverser
npm/acorn-walk@8.3.2 None 0 52.4 kB marijn
npm/acorn@8.11.3 None 0 531 kB marijn
npm/address@1.2.2 environment, filesystem, shell 0 13 kB fengmk2
npm/agent-base@6.0.2 None 0 34.6 kB tootallnate
npm/anymatch@3.1.3 None 0 9.65 kB phated
npm/arr-diff@2.0.0 None 0 5.32 kB jonschlinkert
npm/arr-flatten@1.1.0 None 0 6.88 kB jonschlinkert
npm/arr-union@3.1.0 None 0 6.66 kB jonschlinkert
npm/array-uniq@1.0.3 None 0 3.57 kB sindresorhus
npm/array-unique@0.2.1 None 0 4.43 kB jonschlinkert
npm/assert-plus@1.0.0 environment 0 11.4 kB pfmooney
npm/assign-symbols@1.0.0 None 0 5.85 kB phated
npm/astral-regex@2.0.0 None 0 3.4 kB kevva
npm/async-each@1.0.6 None 0 4.4 kB paulmillr
npm/async@2.6.4 None 0 541 kB hargasinski
npm/asynckit@0.4.0 None 0 27.4 kB alexindigo
npm/atob@2.1.2 None 0 36.2 kB coolaj86
npm/aws-sign2@0.7.0 None 0 14.2 kB mikeal
npm/aws4@1.12.0 environment 0 23.5 kB hichaelmart
npm/axios@1.6.8 network 0 1.84 MB jasonsaayman
npm/babel-runtime@6.26.0 Transitive: eval +1 73.6 kB hzoo
npm/balanced-match@1.0.2 None 0 6.94 kB juliangruber
npm/base64-js@1.5.1 None 0 9.62 kB feross
npm/bignumber.js@9.1.2 None 0 351 kB mikemcl
npm/binary-extensions@2.3.0 None 0 5.03 kB sindresorhus
npm/bindings@1.5.0 environment, filesystem 0 11.2 kB tootallnate
npm/browserslist@4.23.0 environment, filesystem 0 62.8 kB ai
npm/buffer-from@1.1.2 None 0 5.05 kB linusu
npm/buffer-writer@2.0.0 None 0 13.7 kB brianc
npm/buffer@6.0.3 None 0 91.3 kB feross
npm/caniuse-lite@1.0.30001615 None 0 2.05 MB caniuse-lite
npm/caseless@0.12.0 None 0 14.3 kB mikeal
npm/chokidar@3.6.0 environment, filesystem 0 90.2 kB paulmillr
npm/chownr@1.1.4 filesystem 0 5.71 kB isaacs
npm/clean-stack@2.2.0 None 0 5.51 kB sindresorhus
npm/cli-boxes@2.2.1 None 0 6.14 kB sindresorhus
npm/cli-spinners@2.9.2 None 0 32.1 kB sindresorhus
npm/cli-width@3.0.0 environment 0 11.5 kB knownasilya
npm/co@4.6.0 None 0 16 kB jongleberry
npm/color-string@1.9.1 None 0 10.1 kB qix
npm/colorette@2.0.20 None 0 17 kB jorgebucaran
npm/combined-stream@1.0.8 None 0 11.5 kB alexindigo
npm/compare-versions@6.1.0 None 0 55.2 kB omichelsen
npm/concat-map@0.0.1 None 0 4.86 kB substack
npm/consola@2.15.3 environment, filesystem 0 123 kB pi0
npm/content-type@1.0.5 None 0 10.5 kB dougwilson
npm/convert-source-map@2.0.0 None 0 15.9 kB phated
npm/core-util-is@1.0.2 None 0 23.2 kB isaacs
npm/crc-32@1.2.2 None 0 31 kB sheetjs
npm/cross-fetch@3.1.8 network 0 75.1 kB lquixada
npm/debug@4.3.4 environment 0 42.4 kB qix
npm/decode-uri-component@0.2.2 None 0 6.09 kB samverschueren
npm/deep-extend@0.6.0 None 0 9.19 kB unclechu
npm/deep-is@0.1.4 None 0 8.11 kB thlorenz
npm/defer-to-connect@1.1.3 network 0 5.45 kB szmarczak
npm/delayed-stream@1.0.0 None 0 8.02 kB apechimp
npm/diff@5.2.0 None 0 429 kB explodingcabbage
npm/doctrine@3.0.0 None 0 106 kB eslint
npm/eastasianwidth@0.2.0 None 0 13.6 kB komagata
npm/ee-first@1.1.1 None 0 6.26 kB dougwilson
npm/electron-to-chromium@1.4.754 None 0 287 kB kilianvalkhof
npm/end-of-stream@1.4.4 None 0 6.23 kB mafintosh
npm/env-paths@2.2.1 None 0 10.2 kB sindresorhus
npm/errno@0.1.8 None 0 18.1 kB ralphtheninja
npm/es6-symbol@3.1.4 None 0 16.5 kB medikoo
npm/escape-html@1.0.3 None 0 3.66 kB dougwilson
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-visitor-keys@3.4.3 None 0 32.3 kB eslintbot
npm/esquery@1.5.0 None 0 1 MB michaelficarra
npm/esrecurse@4.3.0 None 0 13.5 kB michaelficarra
npm/estraverse@5.3.0 None 0 37.1 kB michaelficarra
npm/esutils@2.0.3 None 0 50.6 kB michaelficarra
npm/events@3.3.0 None 0 82.8 kB goto-bus-stop
npm/expand-brackets@0.1.5 None 0 9.33 kB jonschlinkert
npm/expand-range@1.8.2 None +1 28.1 kB jonschlinkert
npm/exponential-backoff@3.1.1 None 0 37.3 kB sssayegh
npm/extend@3.0.2 None 0 23.5 kB ljharb
npm/extsprintf@1.3.0 None 0 22.8 kB dap
npm/fast-diff@1.3.0 None 0 52.3 kB luin
npm/fast-fifo@1.3.2 None 0 5.07 kB mafintosh
npm/fast-json-stable-stringify@2.1.0 None 0 17 kB esp
npm/fast-levenshtein@2.0.6 None 0 9.44 kB hiddentao
npm/fb-watchman@2.0.2 environment, network, shell 0 11 kB bolinfest
npm/filename-regex@2.0.1 None 0 4.35 kB doowb
npm/flat-cache@4.0.1 filesystem 0 29.3 kB jaredwray
npm/flatted@3.3.1 None 0 40.3 kB webreflection
npm/follow-redirects@1.15.6 network 0 29.4 kB rubenverborgh
npm/for-in@1.0.2 None 0 6.28 kB jonschlinkert
npm/forever-agent@0.6.1 network 0 14 kB simov
npm/form-data@4.0.0 filesystem, network 0 43.4 kB niftylettuce
npm/fragment-cache@0.2.1 None 0 9.9 kB jonschlinkert
npm/fs-readdir-recursive@1.1.0 filesystem 0 4.49 kB dead_horse
npm/fs.realpath@1.0.0 environment, filesystem 0 13.4 kB isaacs
npm/fsevents@2.3.3 None 0 173 kB pipobscure
npm/functional-red-black-tree@1.0.1 None 0 43.5 kB mikolalysenko
npm/gensync@1.0.0-beta.2 None 0 28.9 kB loganfsmyth
npm/glob@7.2.3 filesystem 0 55.1 kB isaacs
npm/global-modules@2.0.0 environment 0 6.57 kB jonschlinkert
npm/global-prefix@3.0.0 environment, filesystem 0 8.27 kB jonschlinkert
npm/global@4.4.0 None 0 3.47 kB raynos
npm/globals@11.12.0 None 0 39.8 kB sindresorhus
npm/graphemer@1.4.0 None 0 812 kB mattpauldavies
npm/graphql@16.8.1 None 0 1.34 MB i1g
npm/har-schema@2.0.0 None 0 15.1 kB ahmadnassri
npm/has@1.0.4 None 0 3.02 kB tarruda
npm/hash.js@1.1.7 None 0 41.7 kB indutny
npm/he@1.2.0 None 0 124 kB mathias
npm/http-signature@1.2.0 network 0 48.4 kB arekinath
npm/https-proxy-agent@5.0.1 network 0 26 kB tootallnate
npm/ieee754@1.2.1 None 0 6.8 kB feross
npm/imurmurhash@0.1.4 None 0 11.9 kB jensyt
npm/inflight@1.0.6 None 0 3.76 kB isaacs
npm/is-accessor-descriptor@1.0.1 None 0 20.3 kB ljharb
npm/is-binary-path@2.1.0 None 0 3.08 kB sindresorhus
npm/is-buffer@2.0.5 None 0 4.59 kB feross
npm/is-data-descriptor@1.0.1 None 0 18.8 kB ljharb
npm/is-docker@2.2.1 filesystem 0 3.01 kB sindresorhus
npm/is-path-inside@3.0.3 None 0 4.12 kB sindresorhus
npm/is-plain-object@2.0.4 None 0 7.5 kB jonschlinkert
npm/is-typedarray@1.0.0 None 0 4.41 kB hughsk
npm/is-unicode-supported@0.1.0 None 0 3.54 kB sindresorhus
npm/is-wsl@2.2.0 environment, filesystem 0 3.76 kB sindresorhus
npm/isobject@3.0.1 None 0 6.93 kB doowb
npm/isstream@0.1.2 None 0 13.3 kB rvagg
npm/jackspeak@2.3.6 environment 0 253 kB isaacs
npm/jsbn@0.1.1 None 0 45.8 kB andyperlitch
npm/jsesc@2.5.2 None 0 32 kB mathias
npm/json-buffer@3.0.1 None 0 5.4 kB dominictarr
npm/json-stable-stringify-without-jsonify@1.0.1 None 0 14.2 kB samn
npm/json-stringify-safe@5.0.1 None 0 12.7 kB isaacs
npm/json5@2.2.3 None 0 235 kB jordanbtucker
npm/keyv@4.5.4 None 0 27.8 kB jaredwray
npm/levn@0.4.1 None 0 24.9 kB gkz
npm/lodash.get@4.4.2 None 0 26.5 kB jdalton
npm/lodash.truncate@4.4.2 None 0 19.8 kB jdalton
npm/loose-envify@1.4.0 environment 0 5.81 kB zertosh
npm/lru_map@0.3.3 None 0 39.2 kB rsms
npm/map-cache@0.2.2 None 0 7.6 kB jonschlinkert
npm/markdown-table@1.1.3 None 0 12 kB wooorm
npm/mime-db@1.52.0 None 0 206 kB dougwilson
npm/mime-types@2.1.35 None 0 18.3 kB dougwilson
npm/mime@1.6.0 environment, filesystem 0 51.7 kB broofa
npm/mimic-response@1.0.1 None 0 3.58 kB sindresorhus
npm/min-document@2.19.0 None 0 54.9 kB raynos
npm/minimalistic-assert@1.0.1 None 0 1.55 kB cwmma
npm/minipass@7.0.4 None 0 285 kB isaacs
npm/mkdirp@0.5.6 filesystem 0 7.69 kB isaacs
npm/mute-stream@0.0.8 None 0 6.51 kB isaacs
npm/nan@2.19.0 None 0 429 kB kkoopa
npm/nanoid@3.3.7 None 0 24.4 kB ai
npm/natural-compare@1.4.0 None 0 5.65 kB megawac
npm/neo-async@2.6.2 None 0 298 kB suguru03
npm/node-int64@0.4.0 None 0 16.3 kB broofa
npm/node-releases@2.0.14 None 0 34 kB chicoxyzzy
npm/normalize-path@3.0.0 None 0 9.22 kB jonschlinkert
npm/oauth-sign@0.9.0 None 0 13.8 kB simov
npm/object-assign@4.1.1 None 0 5.49 kB sindresorhus
npm/object.omit@2.0.1 None 0 7.92 kB jonschlinkert
npm/object.pick@1.3.0 None 0 6.36 kB phated
npm/once@1.4.0 None 0 4.05 kB isaacs
npm/optionator@0.9.4 None 0 50.2 kB gkz
npm/p-finally@1.0.0 None 0 3.11 kB sindresorhus
npm/packet-reader@1.0.0 None 0 10 kB brianc
npm/parse-glob@3.0.4 None +1 16.1 kB jonschlinkert
npm/path-is-absolute@1.0.1 None 0 3.62 kB sindresorhus
npm/path-root-regex@0.1.2 None 0 4.79 kB jonschlinkert
npm/path-scurry@1.10.2 filesystem +1 1.21 MB isaacs
npm/performance-now@2.1.0 None 0 11.3 kB meryn
npm/pg-connection-string@2.6.4 filesystem 0 9.1 kB brianc
npm/pg-int8@1.0.1 None 0 3.19 kB charmander
npm/pg-protocol@1.6.1 None 0 188 kB brianc
npm/pinkie-promise@2.0.1 None 0 2.58 kB floatdrop
npm/posix-character-classes@0.1.1 None 0 6.97 kB jonschlinkert
npm/postgres-array@2.0.0 None 0 4.9 kB bendrucker
npm/postgres-bytea@1.0.0 None 0 3.06 kB bendrucker
npm/postgres-date@1.0.7 None 0 5.92 kB bendrucker
npm/prelude-ls@1.2.1 None 0 36.7 kB gkz
npm/prepend-http@2.0.0 None 0 2.98 kB sindresorhus
npm/preserve@0.2.0 None 0 9.42 kB jonschlinkert
npm/prettier-linter-helpers@1.0.0 None 0 9.58 kB bpscott
npm/process-nextick-args@2.0.1 None 0 3.17 kB cwmma
npm/process@0.11.10 None 0 15.3 kB cwmma
npm/proxy-from-env@1.1.0 environment 0 29.5 kB rob-w
npm/psl@1.9.0 None 0 461 kB lupomontero
npm/pump@3.0.0 filesystem 0 7.78 kB mafintosh
npm/qs@6.5.3 None 0 126 kB ljharb
npm/randombytes@2.1.0 None 0 6.36 kB cwmma
npm/readdirp@3.6.0 filesystem 0 20.5 kB paulmillr
npm/regenerate@1.4.2 None 0 49.2 kB mathias
npm/regex-cache@0.4.4 None 0 9.88 kB doowb
npm/regex-not@1.0.2 None 0 8.46 kB jonschlinkert
npm/remove-trailing-separator@1.1.0 None 0 4.25 kB darsain
npm/repeat-element@1.1.4 None 0 5.39 kB jonschlinkert
npm/repeat-string@1.6.1 None 0 9.09 kB jonschlinkert
npm/ret@0.1.15 None 0 17.9 kB fent
npm/rfdc@1.3.1 None 0 25.2 kB matteo.collina
npm/run-async@2.4.1 None 0 6.6 kB sboudrias
npm/rxjs@7.8.1 None 0 4.5 MB blesh
npm/safe-regex@1.1.0 None 0 5.87 kB substack
npm/simple-swizzle@0.2.2 None +1 58.3 kB qix
npm/source-map-resolve@0.5.3 None 0 34.3 kB lydell
npm/source-map@0.6.1 None 0 805 kB tromey
npm/split-string@3.1.0 None +1 22.4 kB jonschlinkert
npm/strip-json-comments@3.1.1 None 0 6.96 kB sindresorhus
npm/text-table@0.2.0 None 0 11 kB substack
npm/to-fast-properties@2.0.0 None 0 3.5 kB sindresorhus
npm/to-readable-stream@1.0.0 None 0 2.79 kB sindresorhus
npm/tough-cookie@2.5.0 network 0 86.6 kB jstash
npm/tr46@0.0.3 None 0 268 kB sebmaster
npm/ts-api-utils@1.3.0 None 0 828 kB joshuakgoldberg
npm/tunnel-agent@0.6.0 environment, network 0 16.7 kB mikeal
npm/type-check@0.4.0 None 0 21.2 kB gkz
npm/type-detect@4.0.8 None 0 42.1 kB chaijs
npm/typedarray-to-buffer@3.1.5 None 0 8.84 kB feross
npm/uglify-js@3.17.4 environment, eval, filesystem 0 1.28 MB alexlamsl
npm/unc-path-regex@0.1.2 None 0 4.93 kB tunnckocore
npm/undici@5.28.4 environment, network, unsafe 0 1.17 MB matteo.collina
npm/update-browserslist-db@1.0.14 environment 0 14 kB ai
npm/use@3.1.1 None 0 9.51 kB jonschlinkert
npm/uuid@8.3.2 None 0 116 kB ctavan
npm/web-streams-polyfill@3.3.3 None 0 9.04 MB mattiasbuelens
npm/webidl-conversions@3.0.1 None 0 12.4 kB sebmaster
npm/whatwg-url@5.0.0 None 0 49.9 kB domenic
npm/word-wrap@1.2.5 None 0 11.8 kB jonschlinkert
npm/wordwrap@1.0.0 None 0 36.8 kB substack
npm/wrappy@1.0.2 None 0 2.96 kB zkat
npm/xtend@4.0.2 None 0 6.46 kB raynos
npm/yaml@1.10.2 environment 0 448 kB eemeli
npm/zod@3.23.6 None 0 666 kB colinmcd94

🚮 Removed packages: npm/@0no-co/graphql.web@1.0.4, npm/@ampproject/remapping@2.2.1, npm/@arbitrum/sdk@3.1.13, npm/@babel/highlight@7.24.5, npm/@changesets/apply-release-plan@7.0.0, npm/@changesets/assemble-release-plan@6.0.0, npm/@changesets/changelog-git@0.2.0, npm/@changesets/cli@2.27.1, npm/@changesets/config@3.0.0, npm/@changesets/errors@0.2.0, npm/@changesets/get-dependents-graph@2.0.0, npm/@changesets/get-release-plan@4.0.0, npm/@changesets/get-version-range-type@0.4.0, npm/@changesets/git@3.0.0, npm/@changesets/logger@0.1.0, npm/@changesets/parse@0.4.0, npm/@changesets/pre@2.0.0, npm/@changesets/read@0.6.0, npm/@changesets/types@6.0.0, npm/@changesets/write@0.3.0, npm/@commitlint/cli@18.6.1, npm/@commitlint/config-conventional@18.6.3, npm/@commitlint/config-validator@18.6.1, npm/@commitlint/ensure@18.6.1, npm/@commitlint/execute-rule@18.6.1, npm/@commitlint/format@18.6.1, npm/@commitlint/is-ignored@18.6.1, npm/@commitlint/lint@18.6.1, npm/@commitlint/load@18.6.1, npm/@commitlint/message@18.6.1, npm/@commitlint/parse@18.6.1, npm/@commitlint/read@18.6.1, npm/@commitlint/resolve-extends@18.6.1, npm/@commitlint/rules@18.6.1, npm/@commitlint/to-lines@18.6.1, npm/@commitlint/top-level@18.6.1, npm/@commitlint/types@18.6.1, npm/@ethersproject/abi@5.7.0, npm/@ethersproject/address@5.7.0, npm/@ethersproject/bignumber@5.7.0, npm/@ethersproject/bytes@5.7.0, npm/@ethersproject/keccak256@5.7.0, npm/@ethersproject/logger@5.7.0, npm/@ethersproject/rlp@5.7.0, npm/@manypkg/find-root@1.1.0, npm/@manypkg/get-packages@1.1.3, npm/@types/mocha@9.1.1, npm/@types/node@12.20.55, npm/@types/node@20.12.8, npm/@types/normalize-package-data@2.4.4, npm/ajv@8.13.0, npm/array-ify@1.0.0, npm/async-mutex@0.4.1, npm/better-path-resolve@1.0.0, npm/breakword@1.0.6, npm/camelcase-keys@6.2.2, npm/chalk@2.4.2, npm/cliui@6.0.0, npm/color-convert@2.0.1, npm/compare-func@2.0.0, npm/conventional-changelog-angular@7.0.0, npm/conventional-changelog-conventionalcommits@7.0.2, npm/conventional-commits-parser@5.0.0, npm/cosmiconfig-typescript-loader@5.0.0, npm/cosmiconfig@8.3.6, npm/csv-generate@3.4.3, npm/csv-parse@4.16.3, npm/csv-stringify@5.6.5, npm/csv@5.5.3, npm/dargs@7.0.0, npm/defaults@1.0.4, npm/enquirer@2.4.1, npm/ethers@5.7.2, npm/execa@5.1.1, npm/extendable-error@0.1.7, npm/find-up@5.0.0, npm/find-yarn-workspace-root2@1.2.16, npm/fs-extra@7.0.1, npm/git-raw-commits@2.0.11, npm/global-dirs@0.1.1, npm/grapheme-splitter@1.0.4, npm/human-id@1.0.2, npm/is-subdir@1.2.0, npm/is-text-path@2.0.0, npm/js-sha3@0.8.0, npm/jsonparse@1.3.1, npm/jsonstream@1.3.5, npm/load-yaml-file@0.2.0, npm/locate-path@5.0.0, npm/lodash.isfunction@3.0.9, npm/lodash.kebabcase@4.1.1, npm/lodash.mergewith@4.6.2, npm/lodash.snakecase@4.1.1, npm/lodash.startcase@4.4.0, npm/lodash.uniq@4.5.0, npm/meow@6.1.1, npm/minimist-options@4.1.0, npm/mixme@0.5.10, npm/normalize-package-data@3.0.3, npm/onetime@5.1.2, npm/outdent@0.5.0, npm/p-filter@2.1.0, npm/p-locate@5.0.0, npm/p-map@2.1.0, npm/parse-json@5.2.0, npm/pkg-dir@4.2.0, npm/preferred-pm@3.1.3, npm/pseudomap@1.0.2, npm/read-pkg-up@7.0.1, npm/read-yaml-file@1.1.0, npm/readable-stream@3.6.2, npm/require-main-filename@2.0.0, npm/resolve-global@1.0.0, npm/set-blocking@2.0.0, npm/smartwrap@2.0.2, npm/spawndamnit@2.0.0, npm/spdx-exceptions@2.5.0, npm/spdx-expression-parse@3.0.1, npm/spdx-license-ids@3.0.17, npm/stream-transform@2.1.3, npm/string-width@4.2.3, npm/string.prototype.trim@1.2.9, npm/string.prototype.trimend@1.0.8, npm/string.prototype.trimstart@1.0.8, npm/string_decoder@1.3.0, npm/supports-color@7.2.0, npm/term-size@2.2.1, npm/text-extensions@2.4.0, npm/through2@4.0.2, npm/tty-table@4.2.3, npm/typescript@4.9.5, npm/which-module@2.0.1, npm/which-pm@2.0.0, npm/wrap-ansi@6.2.0, npm/xmlhttprequest@1.8.0, npm/yargs@17.7.2

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/fsevents@1.2.13
  • Install script: install
  • Source: node install.js
  • orphan: npm/fsevents@1.2.13

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/fsevents@1.2.13

@tmigone tmigone merged commit eb910f0 into main May 13, 2024
9 of 10 checks passed
@tmigone tmigone deleted the tmigone/allow-early-closure branch May 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maikol Maikol Maikol approved these changes

@pcarranzav pcarranzav pcarranzav left review comments

Assignees
No one assigned
Labels
audited protocol change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmigone @pcarranzav @Maikol