graphman: pause subgraph before reassigning #5256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry this has been sitting for so long. I think the change is totally fine, but I am curious if that really addresses the problem in practice - my experience has been that it can take a while for a subgraph to actually process the pause request. Have you seen that? Do you still get a race when that happens? The basic issue is that the current mechanism for handling assignments doesn't provide a reliable way to say "node x is done with a subgraph so node y can start working on it" which opens the dorr to these races. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5253
The subgraph being reassigned is now paused if it wasn't and is then resumed once the reassigment process is complete.