Check if the indexes are correct #5386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
force-pushed
the
zoran/graphman-copy-init
branch
from
a85eb9b
to
0de704b
Compare
zorancv
force-pushed
the
zoran/graphman-copy
branch
2 times, most recently
from
53067fa
to
423724b
Compare
zorancv
force-pushed
the
zoran/graphman-copy-init
branch
6 times, most recently
from
88f6a1d
to
7ae9393
Compare
zorancv
commented
May 7, 2024
| assert!(ii_vec.len() <= 1); | ||
| // Check if the index is valid. If either isvalid or isready flag of pg_index table | ||
| // isn't true, drop it and recreate it. | ||
| if ii_vec.len() == 0 || !ii_vec[0].isvalid || !ii_vec[0].isready { |
There was a problem hiding this comment.
Criteria for recreating the index is that either inisvalid or indisready is false from pg_index table. If the respective row is completely missing I'd skip dropping the old index and proceed with creating the new one directly. WDYT @lutter
zorancv
commented
May 7, 2024
zorancv
force-pushed
the
zoran/graphman-copy-init
branch
5 times, most recently
from
a63587a
to
82da179
Compare
zorancv
force-pushed
the
zoran/graphman-copy
branch
from
423724b
to
979c440
Compare
zorancv
force-pushed
the
zoran/graphman-copy-init
branch
from
82da179
to
1b825c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat related to the #5140 . Check all the attribute indexes at subgraph start and recreate the invalid ones.