core pkg #1415
Draft
core pkg #1415
+2,135
−813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploying with
|
| Latest commit: |
dffabf7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6666f37.graph-tooling.pages.dev |
| Branch Preview URL: | https://saihaj-create-core-pkg.graph-tooling.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to create a code first interface so building functions/helpers that will be used by the CLI. This can be an API in future we can expose for anyone trying to extend functionality on their own.
Started with the idea of refactoring to use #1394 but soon ran into issues cause everything is very mingled together and it is not very easy to just refactor one piece.
So idea here is create function that we can call and function we can easily test.