Feature | graph init Add support to download spkg files from spkg.io
#1642
Conversation
…ature/graph-init-spkg-io-support
🦋 Changeset detectedLatest commit: 91e488c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshuanazareth97
changed the title
graph init Add support to download spkg files from spkg.io
|
Hi @saihaj can you please review this PR? Let me know if there's anything you need me to do before you merge it. Thanks! |
|
thanks @joshuanazareth97 sorry for the delay. I was away on vacation last week, catching up on things will try to land this early next week |
| import { createWriteStream } from 'fs'; | ||
| import { http } from 'gluegun'; | ||
|
|
||
| export async function downloadFile(fileUrl: string, outputLocationPath: string) { | ||
| const writer = createWriteStream(outputLocationPath); | ||
| const api = http.create({ | ||
| baseURL: fileUrl, | ||
| }); | ||
| return api.get('', {}, { responseType: 'stream' }).then((response: any) => { | ||
| response.data.pipe(writer); | ||
| return Promise.resolve(outputLocationPath); | ||
| }); | ||
| } |
There was a problem hiding this comment.
I would use fetch, we maintain an internal wrapper that also passes some headers that can let origin servers know where the traffic is coming from.
There was a problem hiding this comment.
Have now resolved this to use the wrapped fetch
Co-authored-by: Saihajpreet Singh <saihajpreet.singh@gmail.com>
|
@joshuanazareth97 are you still working on this? |
…anazareth97/graph-tooling into feature/graph-init-spkg-io-support
…ature/graph-init-spkg-io-support
@saihaj apologies, was occupied with some other stuff last week. Have addressed all your comments. |
Change Description
Related Issue / Discussion
#1641
Screenshot of change