Improve service config with examples, more defaults #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aasseman
force-pushed
the
aasseman/improve-service-config
branch
from
620f3f2
to
712976d
Compare
|
Rebased onto latest main |
Pull Request Test Coverage Report for Build 9070262101Details
💛 - Coveralls |
gusinacio
reviewed
May 9, 2024
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
The tests ensure that the config files are up to date with the code. I also looks like freezing `serde_spanned` is not needed anymore + needed to remove it to be able to add `toml`. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Points to the example config files on github. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
So that we can give examples for the shell expansion functionality in comments in the example config files. Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
aasseman
force-pushed
the
aasseman/improve-service-config
branch
from
4723649
to
5771eb6
Compare
|
Rebased onto latest main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanations in the commit messages.