Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended type-checked eslint #754

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Aug 25, 2023

Proposal for using the recommended-type-checked @typescript-eslint plugin, which is the suggested configuration for typescript projects.

Additionally:

  • Type-check all test files.
  • Adds the typescript-eslint-language-server as a development dependency for agnostic integration with editors and IDEs.

This PR will trigger many linter errors, and CI won't pass until we resolve them or adjust the error handling (either ignore or turn them into warnings).

Reference: https://typescript-eslint.io/linting/configs/#recommended-type-checked

@tilacog tilacog added enhancement New feature or request hardening labels Aug 25, 2023
@tilacog tilacog self-assigned this Aug 25, 2023
@tilacog
Copy link
Contributor Author

tilacog commented Aug 28, 2023

One possible approach would be to enable all lints as warnings (not errors) and gradually fix each category, then promote that category (now corrected) to errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hardening
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants