Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor indexer management API layer #859

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Feb 21, 2024

Summary
Rework the indexer-common GraphQL API layer to utilize GraphQL Codegen Server preset with GraphQL Yoga.

Background
When I was working on #858 I noticed that to create new resolver we update the SDL and then manually type out everything. When I was trying to write unit tests there was some bug which was causing my writes to be not written to DB. The setup is uncommon and debugging was just painful. This PR attempts to do something to reduce the pain

What does this PR change?

  1. Brings in code generation
    • Instead of typing manually we utilize code generation
    • Simplify the DB models typings
  2. A compliant GraphQL Server - With URQL setup none of the operations were being validated. I found a lot of inconsistencies within the GraphQL schema which should be caught early on.

This is first attempt to improve DX and make contributions easier. There is a lot more we can clean and improve but this already a large PR so should scope more time for follow-ups.

@saihaj saihaj marked this pull request as ready for review April 2, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant