common: 879 duplicate queued actions - composite index #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwerner
force-pushed
the
879-duplicate-queued-actions-approach=composite-index
branch
from
b6cf500
to
c107704
Compare
… of the same item to actions table
dwerner
force-pushed
the
879-duplicate-queued-actions-approach=composite-index
branch
from
c107704
to
9c8aaee
Compare
|
Converting to a draft as I address some test failures. |
dwerner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #879
After testing seeing #883, I set out to write a unit test that would prove if #879 were indeed resolved.
I ended up with a test that would sporadically fail, depending on timing.
My first approach here was to introduce an advisory lock, which I removed in favor of this PR's composite index and unique constraint on deploymentID and source. Now a GQL validation error occurs when the duplicate is about to be inserted.
Looking for feedback on this approach.